Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ESLint playwright plugin #106

Merged
merged 2 commits into from
Nov 8, 2024
Merged

feat: add ESLint playwright plugin #106

merged 2 commits into from
Nov 8, 2024

Conversation

oltionchampari
Copy link
Contributor

Closes list issues numbers here

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • this would help us avoid some common mistakes and errors when writing tests

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@oltionchampari oltionchampari self-assigned this Nov 7, 2024
@oltionchampari oltionchampari requested a review from a team as a code owner November 7, 2024 13:08
@oltionchampari oltionchampari added release: minor PR merge results in a new minor version type: feature New feature or request labels Nov 7, 2024
thinkh
thinkh requested changes Nov 7, 2024
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the dependency. Other than that it looks good to me.

package.json Outdated
@@ -96,6 +96,7 @@
},
"devDependencies": {
"@types/yargs": "^17.0.33",
"eslint-plugin-playwright": "^2.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, you need to move this to the dependencies because devDependencies are not installed as transitive dependencies. You can see also the other eslint deps above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, learned something new today :)

thinkh
thinkh approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for integrating my feedback. LGTM.

@thinkh thinkh merged commit 44649f2 into develop Nov 8, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Nov 8, 2024
Merged
puehringer added a commit that referenced this pull request Nov 8, 2024
@puehringer
Release 11.3.0 (#107)
6e8d147 
## What's Changed
* feat: add ESLint playwright plugin by @oltionchampari in
#106
* update release.yaml for automated release workflow by @datavisyn-bot
in #102

## New Contributors
* @datavisyn-bot made their first contribution in
#102

**Full Changelog**:
v11.2.0...11.3.0
@thinkh thinkh deleted the coh/add-eslint-playwright-plugin branch November 8, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

@puehringer puehringer Awaiting requested review from puehringer

Assignees

@oltionchampari oltionchampari

Labels
release: minor PR merge results in a new minor version type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oltionchampari @thinkh