-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing an array of packages with or without explicitly declare the package version #218
base: master
Are you sure you want to change the base?
Conversation
Since the author is currently not maintaining this module and I wanted a new option in it for use in my current company, the DKB CodeFactory, I created a fork of it and also published it as a node module. The current version 26.1.0 contains your pull request, which I added manually to the refactored code. I plan to maintain that fork at least mid-term. I invite you to contribute any pull requests or bug reports in case you're interested! Once the original author accepts my request to take over the original module, I might use the shorter original name again. license-checker-dkbcodefactory: |
Co-Authored-By: Christian Flach <[email protected]>
@davglass would you mind to give this a look? :D PS: it's already 6 years since we've interacted on a PR/issue... Time passes by so quickly... (we both contributed to https://github.com/sequelize/sequelize) |
I am sorry to tell you that for now I had to remove my Github repository of that code since I forgot to inform my employer and a small part of it has been done during official work time. So we first have to clarify legal issues. I'll keep you updated here. |
@RSeidelsohn I don't think that issue affects by any means the official project since this PR only contains a comment of you. What may get affected is the npm package you published. |
Yes, sure. The point is that I created a forked version that includes your PR, so you could use that instead. I tried to contact Dav Glass in order to figure out when (or if) he will be able to continue maintaining this repo, but so far he did not respond. So currently I am creating my private repository from this one during my free time, so my employer does not own any rights and I can continue publishing it as open source. |
I now created a new fork containing only code I wrote during my spare time. Please use that one instead of the dkbcodefactory one which I have to discontinue due to legal issues. New repo: license-checker-rseidelsohn |
This will also allow the cli to accept package whitelisting with just the version's major or without version at all: