Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inheritance diagram #2042

Merged

Conversation

bluthej
Copy link
Contributor

@bluthej bluthej commented Dec 25, 2024

Closes #2041.

I think this should do the trick, as per this section of the readthedocs documentation.

I wasn't able to actually test this out myself because I couldn't find a way to test this locally, even in the RTD docs.
It looks like they make users rely on Pull request previews in order to test the config. Are those activated for this repo?

@davidhalter
Copy link
Owner

Thanks a lot for looking into this. I have just enabled pull request previews. That's a really good suggestion. Can you try and force push this change, so we can test if this actually works?

@bluthej bluthej force-pushed the docs/fix-inheritance-diagram branch from 1831b60 to 0315e6e Compare December 28, 2024 15:43
@bluthej
Copy link
Contributor Author

bluthej commented Dec 28, 2024

Sure thing! I just did and then looked at the docs/readthedocs.org:jedi check, clicked on Details which opened the preview and the diagram is showing correctly :)

Thanks for the kind words, I appreciate it!
I've been using jedi everyday for the past year and a half through python-lsp-server, so I'm very grateful that it exists and if I can contribute back even on a very small thing like that I'm very happy :)

@davidhalter
Copy link
Owner

Thanks :)

@davidhalter davidhalter merged commit 6aee460 into davidhalter:master Dec 29, 2024
147 checks passed
@bluthej bluthej deleted the docs/fix-inheritance-diagram branch December 29, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken inheritance diagram in current documentation
2 participants