Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query limit to 20 #12

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix: query limit to 20 #12

merged 1 commit into from
Jul 29, 2024

Conversation

davidhorm
Copy link
Owner

Hot Fix because of https://boardgamegeek.com/thread/3336313/max-20-items-from-xml-api-and-xml-api-2

FYI: e2e tests were failing because playwright didn't like test.describe. need to figure out later.

TODO:

  • add unit testing
  • render error message when API fails like that (instead of spinning forever)

@davidhorm davidhorm merged commit 347d867 into main Jul 29, 2024
1 check failed
@davidhorm davidhorm deleted the fix/query-limit branch July 29, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant