Add --whole-archive
#452
Merged
Add --whole-archive
#452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riverbl
force-pushed
the
whole-archive
branch
from
c8d15f5 to
7ddce79
Compare
libwild/src/parsing.rs
Outdated
| @@ -133,7 +133,8 @@ impl<'data> ParsedInputObject<'data> { | |||
| /// it defines. This is true for archive entries and shared objects for which --as-needed is | |||
| /// true. | |||
| pub(crate) fn is_optional(&self) -> bool { | |||
| self.input.entry.is_some() || (self.is_dynamic() && self.modifiers.as_needed) | |||
| !self.modifiers.whole_archive | |||
| && (self.input.entry.is_some() || (self.is_dynamic() && self.modifiers.as_needed)) | |||
There was a problem hiding this comment.
It looks like the parentheses might be in the wrong spot. The --whole-archive flag shouldn't affect shared objects, but it looks like setting --whole-archive here will cause shared objects to become non-optional even if they're --as-needed.
riverbl
force-pushed
the
whole-archive
branch
from
7ddce79 to
e6b754d
Compare
mati865
reviewed
Feb 20, 2025
riverbl
force-pushed
the
whole-archive
branch
from
e6b754d to
a189e7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #272.
I was getting some funny behaviour where the added test would pass but the option wouldn't work when actually using the linker, but I'm no longer seeing this after rebasing onto latest
main.