Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for different label when bat charging #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add option for different label when bat charging #18

wants to merge 1 commit into from

Conversation

mroote
Copy link
Contributor

@mroote mroote commented Apr 22, 2017

  • Adds an option for a different label when battery has charging status

davidscholberg
davidscholberg requested changes May 5, 2017
View reviewed changes
Copy link
Owner

@davidscholberg davidscholberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are fine, but in order to be backwards compatible with existing configurations, the ChargingLabel variable value should default to Label's value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidscholberg davidscholberg davidscholberg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroote @davidscholberg