Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write warnings for invalid models #16

Open
davidtedfordholt opened this issue Mar 4, 2020 · 2 comments
Open

write warnings for invalid models #16

davidtedfordholt opened this issue Mar 4, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@davidtedfordholt
Copy link
Owner

I'm not entirely sure that we will be able to warn for all of them, but if we find model specifications that don't make sense or don't run we need to document them and create warnings for them. It would be nice if those warnings just returned an empty mbl object instead of erroring the process out.

@davidtedfordholt davidtedfordholt added the enhancement New feature or request label Mar 4, 2020
@davidtedfordholt davidtedfordholt added this to the 0.3 milestone Mar 4, 2020
@mitchelloharawild
Copy link
Collaborator

I'm not sure what you're looking for with an empty mbl object, something like the fabletools::null_model()?

Preventing one modelling error from stopping the process is handled in fabletools::model() via the .safely argument (default TRUE). If a model errors during training, a null_model() will be returned and a the error will be converted to a warning.

@davidtedfordholt
Copy link
Owner Author

I’m always happy to know that a local problem already has a general solution. Thank you! I’ll focus solely on problematically misspecified models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants