You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the labels are printed back-to-front, e.g. attribute 4 ... 1 instead of 1...4.
Changes order of legends: currently, legends are printed back-to-front (with increasing y position value); this PR changes the y position of text and graphics from i-1 to n-i, where n=num_of_labels is the total number of labels. Changes are made to the text and graphical part of the legends.
For the text part: labels is an array of strings, so num_of_labels = length(labels)
[in map_once(labels, args...)]
For the graphical part [in function make_label], the total number of labels is obtained from attributes[:labels], which is an Observable, so I used [] to convert to a normal array (is this the acceptable way of doing this?)
example:
using Makie
using Colors
xspan = 0:.01:4*pi
expm(x) = exp(-x)
fs = [sin, cos, sinc, expm]
y = [fs[i](x) for x in xspan, i in 1:size(fs,1)]
function plot2d(x::Union{AbstractRange,AbstractArray{<: AbstractFloat, 1}}, y::AbstractArray{<: AbstractFloat, 2};legend_desc=[], kwargs...)
scene = Scene()
ny = size(y,2)
colors = distinguishable_colors(ny+1,[RGB(1,1,1)])[2:end]
if size(legend_desc,1) != ny
legend_desc = ["data $i" for i in 1:ny]
end
p=[]
for i in 1:ny
pli=lines!(scene, x, y[:,i], color = colors[i];kwargs...)
push!(p,pli[end])
end
ls = legend(p, legend_desc, camera = campixel!, raw = true)
vbox(scene, ls)
end
@time plot2d(collect(xspan), y, linewidth = 2,legend_desc=string.(fs))
83c2a27There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concerning: MakieOrg/Makie.jl#308 and MakieOrg/Makie.jl#302
e.g. the example listed in MakieOrg/Makie.jl#308,
https://simondanisch.github.io/ReferenceImages/gallery///labels//index.html
the labels are printed back-to-front, e.g. attribute 4 ... 1 instead of 1...4.
Changes order of legends: currently, legends are printed back-to-front (with increasing y position value); this PR changes the y position of text and graphics from
i-1ton-i, wheren=num_of_labelsis the total number of labels. Changes are made to the text and graphical part of the legends.For the text part:
labelsis an array of strings, sonum_of_labels = length(labels)[in
map_once(labels, args...)]For the graphical part [in
function make_label], the total number of labels is obtained fromattributes[:labels], which is anObservable, so I used[]to convert to a normal array (is this the acceptable way of doing this?)example: