Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mac support for hacky script #1

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

zzorica
Copy link
Contributor

@zzorica zzorica commented Mar 27, 2024

Add mac support for hacky script

Description

BSD sed is default one on MacOS so we need to get GNU-compatible sed withbrew install gsed. Scipt will check if its run on MacOS, and if it is, provide option to install gsed if its not already installed.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Related Issue(s)

M/A

Screenshots

N/A

Notes

N/A

@zzorica zzorica force-pushed the add-mac-support-for-hacky-script branch from 16284dd to 75f5780 Compare March 27, 2024 14:45
@Tpuljak Tpuljak merged commit bea79a9 into main Mar 27, 2024
3 checks passed
@Tpuljak Tpuljak deleted the add-mac-support-for-hacky-script branch March 27, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants