Disallow abs() on basic chips #68

dbaumgarten · Aug 4, 2021 · 6eaaf4c · 6eaaf4c
1 parent 4eb35c0
commit 6eaaf4c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/pkg/validators/available_ops.go b/pkg/validators/available_ops.go
@@ -23,7 +23,7 @@ var unavailableBinaryOps = map[string][]string{
 }
 
 var unavailableUnaryOps = map[string][]string{
-	ChipTypeBasic:        {"!", "sqrt", "sin", "cos", "tan", "asin", "acos", "atan"},
+	ChipTypeBasic:        {"!", "sqrt", "sin", "cos", "tan", "asin", "acos", "atan", "abs"},
 	ChipTypeAdvanced:     {"sin", "cos", "tan", "asin", "acos", "atan"},
 	ChipTypeProfessional: {},
 }

diff --git a/pkg/validators/available_ops_test.go b/pkg/validators/available_ops_test.go
@@ -126,6 +126,15 @@ func TestAvailableOps(t *testing.T) {
 			prog:     "x=sin(13)",
 			chiptype: validators.ChipTypeProfessional,
 		},
+		{
+			prog:      "x=abs(13)",
+			chiptype:  validators.ChipTypeBasic,
+			expectErr: true,
+		},
+		{
+			prog:     "x=abs(13)",
+			chiptype: validators.ChipTypeAdvanced,
+		},
 	}
 	for i, entry := range testdata {
 		parsed, err := parser.NewParser().Parse(entry.prog)