Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser permit inline comments (untested) #120

Closed
wants to merge 1 commit into from

Conversation

Woccz
Copy link
Contributor

@Woccz Woccz commented Apr 27, 2022

What this PR does / why we need it**:

Allows for inlining of comments in nolol.
This seems like the simple fix, however if this same parser is used between yolol and nolol, it would allow for inline commenting in yolol, which is illegal.
I am not sure if this is the case?
I am also not certain that the compiler will correctly comment out after the token?

Which issue(s) this PR fixes**:

Fixes #53

Checklist:

  • PR is done against develop-branch
  • includes tests for everything that changed
  • updated documentation (if necessary)

@Woccz Woccz closed this Apr 27, 2022
@Woccz
Copy link
Contributor Author

Woccz commented Apr 27, 2022

Incorrect Parser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant