-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elevate warning to errors for unknown attributes #788
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll also have to update the tests to reflect the change. Some test cases that should be covered:
- Setting an attribute
- Raise an error when setting an unknown attribute is set
- Raise an error when trying to set a readonly attribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Check the removed test
- Add a test that triggers the readonly property error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Use the appropriate assertIn
idiom for the new test and we're done :)
Describe the work done
Replace ConfigureWarning with ConfigureError for unknown attributes
List which issues this resolves:
closes #787
Tasks