Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash completion for services defined in ~/.pg_service.conf #1491

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

3ximus
Copy link
Contributor

@3ximus 3ximus commented Feb 17, 2025

Description

I've added bash completion to services defined in the service file.

It's only triggered after typing service=

I've also cleaned some formatting of the file itself to make it consistent

Checklist

  • I've added this contribution to the changelog.rst.
  • I've added my name to the AUTHORS file (or it's already there).
  • I installed pre-commit hooks (pip install pre-commit && pre-commit install), and ran black on my code.
  • Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

@j-bennet
Copy link
Contributor

j-bennet commented Mar 5, 2025

@3ximus Thank you! Please rebase on top of main, we have an issue with integration tests, and I disabled them for now.

@3ximus
Copy link
Contributor Author

3ximus commented Mar 5, 2025

I'm sorry, in the process of rebasing the pull request was closed automatically however I've rebased it on main. Let me know if all is good. Thank you

@3ximus 3ximus reopened this Mar 5, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.61%. Comparing base (7f05cde) to head (a91a3b2).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1491      +/-   ##
==========================================
- Coverage   80.13%   71.61%   -8.53%     
==========================================
  Files          25       25              
  Lines        3126     3167      +41     
==========================================
- Hits         2505     2268     -237     
- Misses        621      899     +278     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j-bennet j-bennet merged commit b4bec22 into dbcli:main Mar 7, 2025
13 checks passed
@j-bennet
Copy link
Contributor

j-bennet commented Mar 7, 2025

@3ximus It's in. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants