Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dbt-core to 1.5.9 and implement support for model contracts #159

Closed

Conversation

mwallace582
Copy link
Collaborator

@mwallace582 mwallace582 commented Nov 30, 2023

resolves #145

Description

I've followed the instructions published for updating to dbt-core 1.5 and implemented support for model contracts. I targeted 1.5.9 given that it was the latest and greatest version of 1.5.

I was able to get all of the new test classes to pass, and model contracts are working as expected for my dbt models.

There's some trickiness with the difference between types that MySQL allows in schemas, and the types that can be passed into calls to CAST(). I've handed some of the obvious cases, but it's possible that there are gaps with more obscure types.

Not all of my changes are strictly necessary (such as the upgrade to mysql-connector-python). I'd be happy to take any and all feedback.

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md with information about my change

@cknowles
Copy link

cknowles commented Dec 15, 2023

@dbeatty10 is there some way I could help get this PR merged?

@mwallace582
Copy link
Collaborator Author

I'm closing this MR in favor of #163 which contains the same work.

@mwallace582 mwallace582 closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade to support dbt-core v1.5.0
2 participants