Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Problem handling #83

Merged
merged 8 commits into from
Apr 4, 2024
Merged

Add Problem handling #83

merged 8 commits into from
Apr 4, 2024

Conversation

daforster
Copy link
Contributor

No description provided.

@daforster daforster requested a review from clorenz March 27, 2024 11:55
@daforster daforster self-assigned this Mar 27, 2024
@daforster daforster force-pushed the errors-according-to-rfc-7807 branch from ce834c5 to 833bcda Compare March 27, 2024 16:35
@daforster daforster marked this pull request as ready for review March 27, 2024 16:41
return Status.UNPROCESSABLE_ENTITY;
} else if (exc instanceof HttpMediaTypeNotAcceptableException) {
return Status.NOT_FOUND;
} else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vielleicht hier das else entfernen? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eigentlich nicht, damit es ein sauberes if-Statement bleibt. Mit der nächsten Java-Version kann das dann auch auf switch umgebaut werden (ist hier noch experimentell), da wäre das else dann der default-Zweig.

@morpheus-87
Copy link
Member

Bitte die Änderung noch ins Changelog aufnehmen.

@daforster daforster merged commit ed6cc86 into main Apr 4, 2024
3 checks passed
@daforster daforster deleted the errors-according-to-rfc-7807 branch April 4, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants