-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates #20
Open
SengokuNadeko
wants to merge
13
commits into
dboglobal:master
Choose a base branch
from
SengokuNadeko:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Updates #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RP charging aura now changes colors when it's upgraded. Feel free to look over this PR if I made any mistakes ^ I'm not sure how I can fix the position and size of the aura, yet. I think it's a camera issue since the size of the aura changes depending on camera angle.
Guard aura's color now changes depending on jacket's grade!
Dash aura colors now change depending on boots grade level ^
Charge aura's positioning and scaling should work properly now! (Aura also displays properly after modifying the effect)
Item upgrade effects now display properly, for the most part. You can now identify the grade of a player's items from the effect. I still need to implement the extra effects!
Venus project dependencies have been fixed
ModelTool2 project dependencies have been fixed
Solution was retargeted t0 10.0 to solve some compilation issues in the client
The AP meter now mostly displays correctly. When going into areas where flight isn't possible, the meter shows that flight is disabled (it becomes grayed out) and when you return to an area where flight is possible, the meter becomes colored once more. Also, the meter changes colors depending on how much AP you currently have.
Item upgrade effects are now fully working. There are a few tweaks that must be made and some refactoring to be done in the future, but for now this is sufficient.
There was a bug in the AP gui where the proc would be visible in no-flight areas. This small update fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
All auras display their proper color depending on item grade
Charge aura positioning has been corrected and displays properly (check my dbogeffects repo)
Item upgrade effects now display (mostly) properly depending on item grade