Additional Unit Tests Column Logic

[anaghshineh]

Problem

Only the get_nested_column_data_types method in dbt/adapters/bigquery/column.py has unit tests defined. This method relies on other methods to produce its output. These other methods operate recursively and can be difficult to follow for the range of possible inputs (as I found when investigating dbt-labs/dbt-adapters#554). Adding more unit tests to ensure the integrity of these recursive methods would provide developers with a lot more confidence when making changes.

Solution

This PR adds many unit tests for the recursive _update_nested_column_data_types method. These will help ensure the integrity of column-related logic, particularly more complex logic around the handling of nested columns.

Checklist

• I have read the contributing guide and understand what's expected of me
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

[mikealfare]

closing/re-opening to pickup the ok to test label and run integration tests for a green CI

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Alice Naghshineh.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[mikealfare]

@cla-bot check

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Alice Naghshineh.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[mikealfare]

@anaghshineh Can you confirm if you've signed the CLA? The bot previously approved you, but we have been having issues with it lately. If you haven't signed it, could you please sign it? If you have, please let us know and we'll look into it. Thanks!

[anaghshineh]

@anaghshineh Can you confirm if you've signed the CLA? The bot previously approved you, but we have been having issues with it lately. If you haven't signed it, could you please sign it? If you have, please let us know and we'll look into it. Thanks!

Hey, @mikealfare! I previously signed it. I just signed it again. I recently got a new laptop & changed a few configurations in my GitHub account – maybe that's at play?

[mikealfare]

@cla-bot check

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Alice Naghshineh.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Alice Naghshineh.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails