-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE-388] Add group metadata info to LogModelResult
and LogTestResult
#10775
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10775 +/- ##
=======================================
Coverage 89.03% 89.03%
=======================================
Files 182 183 +1
Lines 23195 23215 +20
=======================================
+ Hits 20651 20669 +18
- Misses 2544 2546 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@aranke to check on skipped status for |
LogModelResult
and LogTestResult
LogModelResult
and LogTestResult
LogModelResult
and LogTestResult
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Resolves CORE-388 #10745
Description
LogModelResult
andLogTestResult
for model-level notifications on node pass or fail.LogSkipBecauseError
message.attached_node
toLogTestResult
event if available to get model's FQN.omit_none=True
to prevent [Bug] Unable to parse dict error in logs if email property on a group is not specified #10745.core/dbt/task/group_lookup.py
to centralize group lookup logic in one place and allow it to be accessed in both tasks and runners.Checklist