Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case-sensitivity in validation warning #10807

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Fix case-sensitivity in validation warning #10807

merged 1 commit into from
Oct 1, 2024

Conversation

courtneyholcomb
Copy link
Contributor

@courtneyholcomb courtneyholcomb commented Oct 1, 2024

Problem

In DSI 0.7.2, we released a validation warning that was triggered if a user added a lowercase granularity to a filter in their YAML. This should not have been case sensitive.

Solution

DSI 0.7.3 fixes that issue, so this PR bumps to that version of DSI. See the commit that fixes it here: dbt-labs/dbt-semantic-interfaces#352

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@courtneyholcomb courtneyholcomb added semantic Issues related to the semantic layer community This PR is from a community member labels Oct 1, 2024
@courtneyholcomb courtneyholcomb requested a review from a team as a code owner October 1, 2024 20:18
@cla-bot cla-bot bot added the cla:yes label Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@courtneyholcomb courtneyholcomb added the Skip Changelog Skips GHA to check for changelog file label Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.17%. Comparing base (396cf2d) to head (ebf278f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10807      +/-   ##
==========================================
- Coverage   89.21%   89.17%   -0.05%     
==========================================
  Files         183      183              
  Lines       23457    23457              
==========================================
- Hits        20928    20917      -11     
- Misses       2529     2540      +11     
Flag Coverage Δ
integration 86.41% <ø> (-0.13%) ⬇️
unit 62.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.09% <ø> (ø)
Integration Tests 86.41% <ø> (-0.13%) ⬇️

@emmyoop emmyoop merged commit 7940ad5 into main Oct 1, 2024
82 of 87 checks passed
@emmyoop emmyoop deleted the court/bump-dsi branch October 1, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member semantic Issues related to the semantic layer Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants