Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior change for mf timespine without yaml configuration #10857

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

DevonFulcher
Copy link

@DevonFulcher DevonFulcher commented Oct 15, 2024

Linear issue #SL-2935

Problem

The configuration for the MetricFlow timespine has changed in a previous release. This deprecation warning was previously surfaced in DSI, but that is non-standard for dbt-core usage.

Solution

This PR implements a behavior change to inform users of the deprecation of the old time spine config.

Tests:

  • I ran dbt parse on jaffle-sl-template and saw no warnings
  • I updated jaffle-sl-template to have a metricflow_time_spine.sql model and saw the deprecation warning.
  • I changed the time spine configuration to have a granularity other than day and I saw no warnings.
  • I added this to dbt_project.yaml in jaffle-sl-template and saw no warning for dbt parse:
flags:
  allow_mf_time_spines_without_yaml_configuration: True

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Oct 15, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.13%. Comparing base (ef9abe6) to head (decb313).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10857      +/-   ##
==========================================
- Coverage   89.18%   89.13%   -0.06%     
==========================================
  Files         183      183              
  Lines       23430    23464      +34     
==========================================
+ Hits        20896    20914      +18     
- Misses       2534     2550      +16     
Flag Coverage Δ
integration 86.41% <100.00%> (-0.07%) ⬇️
unit 62.13% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.13% <100.00%> (+0.02%) ⬆️
Integration Tests 86.41% <100.00%> (-0.07%) ⬇️

@DevonFulcher DevonFulcher marked this pull request as ready for review October 22, 2024 14:46
@DevonFulcher DevonFulcher requested a review from a team as a code owner October 22, 2024 14:46
@github-actions github-actions bot added the community This PR is from a community member label Oct 22, 2024
Copy link
Contributor

@courtneyholcomb courtneyholcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parts of the code that I'm familiar with look good to me! Not sure about the protos changes, etc so will need core eyes on those.

In the PR description, I would clarify that the schema has not changed again in case your core reviewer thinks there is a schema change involved in this PR - this is referencing a schema change that has already been released to users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants