-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Behavior change for mf timespine without yaml configuration #10857
base: main
Are you sure you want to change the base?
Behavior change for mf timespine without yaml configuration #10857
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10857 +/- ##
==========================================
- Coverage 89.18% 89.13% -0.06%
==========================================
Files 183 183
Lines 23430 23464 +34
==========================================
+ Hits 20896 20914 +18
- Misses 2534 2550 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parts of the code that I'm familiar with look good to me! Not sure about the protos changes, etc so will need core eyes on those.
In the PR description, I would clarify that the schema has not changed again in case your core reviewer thinks there is a schema change involved in this PR - this is referencing a schema change that has already been released to users.
Linear issue #SL-2935
Problem
The configuration for the MetricFlow timespine has changed in a previous release. This deprecation warning was previously surfaced in DSI, but that is non-standard for dbt-core usage.
Solution
This PR implements a behavior change to inform users of the deprecation of the old time spine config.
Tests:
dbt parse
onjaffle-sl-template
and saw no warningsjaffle-sl-template
to have ametricflow_time_spine.sql
model and saw the deprecation warning.dbt_project.yaml
injaffle-sl-template
and saw no warning fordbt parse
:Checklist