-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add adapter telemetry to snowplow event. #10859
base: main
Are you sure you want to change the base?
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
1 similar comment
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10859 +/- ##
===========================================
- Coverage 89.15% 62.11% -27.04%
===========================================
Files 183 183
Lines 23443 23445 +2
===========================================
- Hits 20901 14564 -6337
- Misses 2542 8881 +6339
Flags with carried forward coverage won't be shown. Click here to find out more.
|
core/dbt/task/run.py
Outdated
@@ -133,6 +139,7 @@ def track_model_run(index, num_nodes, run_model_result): | |||
"contract_enforced": contract_enforced, | |||
"access": access, | |||
"versioned": versioned, | |||
"adapter_info": asdict(adapter_info), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered that this should be something JSON safe, which a Python dict is 🫡
Resolves dbt-labs/dbt-adapters#301
Solution
We propose exposing a method on the base adapter that will use existing snowplow infrastructure for tracking user statistics for any adapter.
We designed the json schema and event data to make it easy for us to add additional per-adapter information as use-cases emerge.
Checklist