Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python 3.8 for dbt 1.7 #10870

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

peterallenwebb
Copy link
Contributor

Problem

Python 3.8 is EOL and no longer supported by some of dbt's upstream build dependencies.

Solution

We are ending support for 3.8 in all future releases, and will no longer test against it.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

* Remove Python 3.8 from various places

* Add changelog entry.

---------

Co-authored-by: Peter Allen Webb <[email protected]>
@peterallenwebb peterallenwebb requested review from a team as code owners October 16, 2024 21:13
@peterallenwebb peterallenwebb requested review from chrismorrisette-dbt and removed request for a team October 16, 2024 21:13
@cla-bot cla-bot bot added the cla:yes label Oct 16, 2024
@peterallenwebb peterallenwebb changed the base branch from main to 1.7.latest October 16, 2024 21:14
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.65%. Comparing base (7c5c54a) to head (5b9cedf).
Report is 1 commits behind head on 1.7.latest.

Files with missing lines Patch % Lines
core/setup.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           1.7.latest   #10870      +/-   ##
==============================================
- Coverage       86.73%   86.65%   -0.09%     
==============================================
  Files             179      179              
  Lines           26728    26728              
==============================================
- Hits            23183    23161      -22     
- Misses           3545     3567      +22     
Flag Coverage Δ
integration 83.46% <0.00%> (-0.18%) ⬇️
unit 65.12% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterallenwebb peterallenwebb changed the title Remove python 3.8 for dbt-core 1.7 Remove python 3.8 for dbt 1.7 Oct 17, 2024
@peterallenwebb peterallenwebb merged commit d75689f into 1.7.latest Oct 18, 2024
56 of 57 checks passed
@peterallenwebb peterallenwebb deleted the remove_python_3.8_for_1.7 branch October 18, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants