Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency pins: click<9 + sqlparse<0.5 #8146

Closed
wants to merge 3 commits into from

Conversation

jtcohen6
Copy link
Contributor

resolves #8145

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@jtcohen6 jtcohen6 requested a review from a team as a code owner July 19, 2023 10:37
@jtcohen6 jtcohen6 requested review from emmyoop and VersusFacit and removed request for a team July 19, 2023 10:37
@cla-bot cla-bot bot added the cla:yes label Jul 19, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@jtcohen6 jtcohen6 requested a review from a team as a code owner July 19, 2023 10:38
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #8146 (2c8856d) into main (cbfc6a8) will decrease coverage by 21.13%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #8146       +/-   ##
===========================================
- Coverage   86.16%   65.03%   -21.13%     
===========================================
  Files         174      174               
  Lines       25493    25493               
===========================================
- Hits        21966    16580     -5386     
- Misses       3527     8913     +5386     
Impacted Files Coverage Δ
core/setup.py 0.00% <ø> (ø)

... and 118 files with indirect coverage changes

@jtcohen6
Copy link
Contributor Author

There still appear to be lots of failures in mypy:

core/dbt/semver.py:111: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
core/dbt/semver.py:112: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
core/dbt/contracts/graph/unparsed.py:231: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
...

Also not sure why code coverage would have declined so dramatically. I'll close this PR for now, but we should take another crack at this soon.

@gshank
Copy link
Contributor

gshank commented Jul 19, 2023

The "annotation-unchecked" things weren't reported like this in an earlier version of mypy. They don't show up if there are no other mypy errors. I don't know why the code coverage numbers would have changed. Unless I'm misunderstanding something, I wouldn't think that would be related to the mypy messages.

@emmyoop emmyoop mentioned this pull request Jul 28, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2846] Update dependency pins: click<9 + sqlparse<0.5
2 participants