Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributor to 1.1.0 release #9284

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

dbeatty10
Copy link
Contributor

resolves https://github.com/dbt-labs/dbt-core/pull/4618/files#r799340999

Problem

We accidentally missed a contributor when we replaced #4159 with #4618

Solution

Just grabbed the code suggestion from https://github.com/dbt-labs/dbt-core/pull/4618/files#r799340999 and opened a pull request 😎

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue If the Markdown is malformed then we can just open a new PR
  • Tests are not required/relevant for this PR
  • This PR has no interface changes
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Dec 13, 2023
@dbeatty10 dbeatty10 added ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering and removed cla:yes labels Dec 13, 2023
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@dbeatty10 dbeatty10 added the Skip Changelog Skips GHA to check for changelog file label Jan 22, 2024
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤟

@cla-bot cla-bot bot added the cla:yes label Sep 26, 2024
@dbeatty10
Copy link
Contributor Author

@ChenyuLInx do you have permissions to force a squash and merge?

Otherwise, we'll just need to close this as not planned.

Here's what I'm seeing:

image

@ChenyuLInx ChenyuLInx merged commit 5250b2f into 1.1.latest Sep 26, 2024
14 of 26 checks passed
@ChenyuLInx ChenyuLInx deleted the dbeatty/add-contributor branch September 26, 2024 22:04
@ChenyuLInx
Copy link
Contributor

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants