Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix governance exclusion macro #403

Merged
merged 2 commits into from
Dec 12, 2023
Merged

fix governance exclusion macro #403

merged 2 commits into from
Dec 12, 2023

Conversation

dave-connors-3
Copy link
Collaborator

This is a:

  • bug fix PR with no breaking changes
  • new functionality

Link to Issue

Closes #396

Description & motivation

Governance models were made without the correct macro call to exclude models -- this should fix it!

Integration Test Screenshot

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
    • Databricks
    • DuckDB
    • Trino/Starburst
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@dave-connors-3 dave-connors-3 changed the title update macro call to model.name from this fix governance exlcusion macro Dec 12, 2023
@dave-connors-3 dave-connors-3 changed the title fix governance exlcusion macro fix governance exclusion macro Dec 12, 2023
@dave-connors-3 dave-connors-3 merged commit 821c013 into main Dec 12, 2023
@dave-connors-3 dave-connors-3 deleted the dc/fix-governance-exclusion branch December 12, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graciegoheen graciegoheen graciegoheen approved these changes

@b-per b-per Awaiting requested review from b-per b-per is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Governance model exceptions do not work like other exceptions
2 participants
@dave-connors-3 @graciegoheen