Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow larger strings for descriptions #445

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

b-per
Copy link
Collaborator

@b-per b-per commented Apr 11, 2024

This is a:

  • bug fix PR with no breaking changes
  • new functionality

Link to Issue

Fixes #437

Description & motivation

This change allows Redhsift users to define a larger varchar size for the description column, without having to change the default size for every varchar column.

Integration Test Screenshot

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
    • Databricks
    • DuckDB
    • Trino/Starburst
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@dave-connors-3 dave-connors-3 merged commit cf65455 into main Apr 11, 2024
11 checks passed
@dave-connors-3 dave-connors-3 deleted the fix-allow-description-larger-string branch April 11, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

value too long for type character varying(600) when building new columns models
2 participants