Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure we catch single character dbs and schemas #509

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

dave-connors-3
Copy link
Collaborator

This is a:

  • bug fix PR with no breaking changes
  • new functionality

Link to Issue

Clsoes #454

Description & motivation

Makes sure we handle single character db.schema.table and schema.table patterns like

select * from a.b.c

and

select * from a.b

no adjustment select * from a to not affect detection of CTE names

Integration Test Screenshot

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
    • Databricks
    • DuckDB
    • Trino/Starburst
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@dave-connors-3 dave-connors-3 merged commit 0417914 into main Oct 25, 2024
11 checks passed
@dave-connors-3 dave-connors-3 deleted the dc/regex-coverage-haha branch October 25, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants