Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADAP-608: Finalize Materialized Views #527

Closed
wants to merge 16 commits into from
Closed

ADAP-608: Finalize Materialized Views #527

wants to merge 16 commits into from

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Jul 11, 2023 •
edited
Loading

resolves dbt-labs/dbt-core#6911
docs dbt-labs/docs.getdbt.com/#

Problem

Implementation of dbt-labs/dbt-core#7985 for dbt-redshift

Solution

Apply approach used for dbt-postgres

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Jul 11, 2023
@cla-bot cla-bot bot added the cla:yes label Jul 11, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

1 similar comment
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@mikealfare mikealfare marked this pull request as ready for review July 12, 2023 05:52
@mikealfare mikealfare requested a review from a team as a code owner July 12, 2023 05:52
@mikealfare mikealfare requested a review from Fleid July 12, 2023 05:52
@mikealfare mikealfare marked this pull request as draft August 2, 2023 18:19
@mikealfare
Copy link
Contributor Author

This PR is way out of date. The branch will be saved for reference, but the PR is stale.

@mikealfare mikealfare closed this Sep 11, 2023
@mikealfare mikealfare deleted the feature/materialized-views/ADAP-608 branch July 17, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fleid Fleid Awaiting requested review from Fleid Fleid is a code owner automatically assigned from dbt-labs/adapters

Assignees

@mikealfare mikealfare

Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-2068] [Feature] Let's add Materialized View as a materialization, finally
1 participant
@mikealfare