Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.9.latest] Combine the build and check build jobs into one job #986

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Jan 30, 2025

Backport of #985, but using the setup.py based build tools instead of pyproject.toml build tools.

…the matrix and avoiding the need to upload and download the artifacts
@mikealfare mikealfare self-assigned this Jan 30, 2025
@mikealfare mikealfare requested a review from a team as a code owner January 30, 2025 22:32
@cla-bot cla-bot bot added the cla:yes label Jan 30, 2025
@mikealfare mikealfare added Skip Changelog Skips GHA to check for changelog file and removed cla:yes labels Jan 30, 2025
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@cla-bot cla-bot bot added the cla:yes label Jan 30, 2025
@mikealfare mikealfare merged commit afe2286 into 1.9.latest Jan 31, 2025
47 checks passed
@mikealfare mikealfare deleted the fix-build-verification-setup-py branch January 31, 2025 01:15
Copy link
Contributor

The backport to 1.8.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8.latest 1.8.latest
# Navigate to the new working tree
cd .worktrees/backport-1.8.latest
# Create a new branch
git switch --create backport-986-to-1.8.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 afe228689fa3510596253e2ee9435a570221899d
# Push it to GitHub
git push --set-upstream origin backport-986-to-1.8.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8.latest

Then, create a pull request where the base branch is 1.8.latest and the compare/head branch is backport-986-to-1.8.latest.

mikealfare added a commit that referenced this pull request Jan 31, 2025
… job (#986)

* combine the build and check build jobs into one job, benefiting from the matrix and avoiding the need to upload and download the artifacts

* install postgresql for macos build checks to get pg_config
mikealfare added a commit that referenced this pull request Jan 31, 2025
… job (#986)

* combine the build and check build jobs into one job, benefiting from the matrix and avoiding the need to upload and download the artifacts

* install postgresql for macos build checks to get pg_config
mikealfare added a commit that referenced this pull request Jan 31, 2025
… job (#986)

* combine the build and check build jobs into one job, benefiting from the matrix and avoiding the need to upload and download the artifacts

* install postgresql for macos build checks to get pg_config
mikealfare added a commit that referenced this pull request Jan 31, 2025
… job (#986)

* combine the build and check build jobs into one job, benefiting from the matrix and avoiding the need to upload and download the artifacts

* install postgresql for macos build checks to get pg_config
mikealfare added a commit that referenced this pull request Jan 31, 2025
… job (#986)

* combine the build and check build jobs into one job, benefiting from the matrix and avoiding the need to upload and download the artifacts

* install postgresql for macos build checks to get pg_config
mikealfare added a commit that referenced this pull request Jan 31, 2025
…#987)

* [Backport 1.9.latest] Combine the build and check build jobs into one job (#986)

* combine the build and check build jobs into one job, benefiting from the matrix and avoiding the need to upload and download the artifacts

* install postgresql for macos build checks to get pg_config

* update dbt-adapters ref for monorepo subdirectory (#984)
mikealfare added a commit that referenced this pull request Jan 31, 2025
… job (#986) (#988)

* combine the build and check build jobs into one job, benefiting from the matrix and avoiding the need to upload and download the artifacts

* install postgresql for macos build checks to get pg_config
mikealfare added a commit that referenced this pull request Jan 31, 2025
… job (#986) (#989)

* combine the build and check build jobs into one job, benefiting from the matrix and avoiding the need to upload and download the artifacts

* install postgresql for macos build checks to get pg_config
mikealfare added a commit that referenced this pull request Jan 31, 2025
… job (#986) (#990)

* combine the build and check build jobs into one job, benefiting from the matrix and avoiding the need to upload and download the artifacts

* install postgresql for macos build checks to get pg_config
mikealfare added a commit that referenced this pull request Jan 31, 2025
… job (#986) (#991)

* combine the build and check build jobs into one job, benefiting from the matrix and avoiding the need to upload and download the artifacts

* install postgresql for macos build checks to get pg_config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.8.latest cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants