Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microbatch Strategy #1108

Merged
merged 14 commits into from
Sep 25, 2024
Merged

Microbatch Strategy #1108

merged 14 commits into from
Sep 25, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Sep 19, 2024

resolves #1109
docs dbt-labs/docs.getdbt.com/#

Problem

As part of dbt-labs/dbt-core#10624, dbt-spark needs to implement a microbatch incremental strategy.

Solution

  • In spark, this will use the insert_overwrite strategy and explicitly require a partition_by field.
  • testing against same profiles as insert_overwrite testing
  • testing against parquet, since it supports timestamp partitioning

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Sep 19, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

@MichelleArk MichelleArk changed the title first pass: microbatch Microbatch Strategy Sep 24, 2024
@MichelleArk MichelleArk marked this pull request as ready for review September 25, 2024 14:55
@MichelleArk MichelleArk requested a review from a team as a code owner September 25, 2024 14:55
@MichelleArk MichelleArk merged commit 101aad2 into main Sep 25, 2024
22 checks passed
@MichelleArk MichelleArk deleted the microbatch-strategy branch September 25, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dbt-spark] Microbatch Incremental Strategy
2 participants