-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add cross db ceiling macro #332
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3a4413c
add ceiling util
emilieschario 897947a
add docs and test
emilieschario 2d1c01b
readd space
emilieschario ff7e443
add back spaces
emilieschario d5d9f2b
match formatting
emilieschario 83c8350
make ceil singular
emilieschario d14eabf
Update integration_tests/models/cross_db_utils/test_ceil.sql
emilieschario 380d660
Update macros/cross_db_utils/ceil.sql
emilieschario File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
input,output | ||
2.0,2.0 | ||
2.3,3.0 | ||
2.8,3.0 | ||
2.5,3.0 | ||
-2.3,-2.0 | ||
-2.8,-2.0 | ||
-2.5,-2.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
|
||
with data as ( | ||
|
||
select * from {{ ref('data_ceil') }} | ||
|
||
) | ||
|
||
select | ||
{{ dbt_utils.ceil('input') }} as actual, | ||
output as expected | ||
|
||
from data |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{% macro ceil(field) -%} | ||
{{ return(adapter.dispatch('ceil', packages = dbt_utils._get_utils_namespaces())(field)) }} | ||
{%- endmacro %} | ||
|
||
{% macro default__ceil(field) -%} | ||
ceil({{ field }}) | ||
{%- endmacro %} | ||
|
||
{% macro alternative_ceil(field) %} | ||
ceiling({{ field }}) | ||
{% endmacro %} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which adapters need to use
ceiling
overceil
? We'll want to adjust this to something like:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's spark specifically (so dbx, but I thought it took the default then the alternative then database specific ones? since there was only on alternative (redshift, bq, and snowflake are all ceil), I thought one catchall might make more sense? If you don't think so, I can move this PR to spark_utils.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess in both cases we'd need the default in dbt-utils, and the override in spark utils. Since none of our core adapters use
ceiling
, I think we'd want the spark-specific version over in spark-utils