Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metric nodes depends_on #3733

Merged
merged 9 commits into from
Jul 15, 2023
Merged

metric nodes depends_on #3733

merged 9 commits into from
Jul 15, 2023

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Jul 13, 2023 •
edited
Loading

adding language that metric nodes include dependencies on semantic models based on measures but not filters in dag and dbt selection.

Resolves #3682

@mirnawong1 mirnawong1 requested a review from a team as a code owner July 13, 2023 16:17
@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs labels Jul 13, 2023
@netlify
Copy link

netlify bot commented Jul 13, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 4e2e1a9
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64b1e4e15171bb00082e51b7
😎 Deploy Preview https://deploy-preview-3733--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the size: small This change will take 1 to 2 days to address label Jul 13, 2023
@mirnawong1
Copy link
Contributor Author

hey @QMalcolm , this resolves #3682 but would love you 👀 on this please for technical accuracy 🙏

@runleonarun
Copy link
Collaborator

runleonarun commented Jul 13, 2023 •
edited
Loading

After you review this @QMalcolm, I will jump in and use a partial for this content so we don't have to maintain two versions of similar content.

Nice work, Mirna!

QMalcolm
QMalcolm approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wonderful! Thank you for doing this write-up 🚀

@dbeatty10
Copy link
Contributor

Partial added @runleonarun !

Enabling auto-merge.

@dbeatty10 dbeatty10 enabled auto-merge (squash) July 15, 2023 00:14
@dbeatty10 dbeatty10 merged commit 2737ec1 into current Jul 15, 2023
11 checks passed
@dbeatty10 dbeatty10 deleted the mwong-metric-nodes branch July 15, 2023 00:22
@runleonarun
Copy link
Collaborator

Thank you @dbeatty10!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbeatty10 dbeatty10 dbeatty10 left review comments

@QMalcolm QMalcolm QMalcolm approved these changes

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
dbt Core v1.6 Documentation
Development

Successfully merging this pull request may close these issues.

Metric nodes depends_on will include semantic_models based on measures, but not based on filters
4 participants
@mirnawong1 @runleonarun @dbeatty10 @QMalcolm