Add LA Store and HealthNut Customer persona #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwenwindflower
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some minor refactoring, notably around the saving CSVs logic to use list comprehensions over generators to evaluate to a list of dicts and the
pd.from_recordsmethod overpd.from_dictwhich expects a list of dictionaries. The old way worked but made linters unhappy. There are now no more warnings from the linter with basic type checking on. (I expect there are lots of warnings if you switch to strict, but I've implemented a bit more typing).It also adds a test to ensure that order totals do indeed equal subtotal + tax_paid, there were some issues with this and rounding in the data before when building on this data in dbt. This should ensure that the source data is not the problem.
It also makes Customer into an ABC, which it is.
It also fixes #111
Lastly it adds a HealthNut persona who primarily buys beverages on summer mornings and an LA location.