Tests for custom offset window #1585
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
force-pushed
the
court/custom-offset7
branch
from
f5b1e3a to
a719cb6
Compare
courtneyholcomb
force-pushed
the
court/custom-offset7
branch
2 times, most recently
from
0048a87 to
33fe95d
Compare
courtneyholcomb
force-pushed
the
court/custom-offset6
branch
from
e91fd30 to
7e13cf3
Compare
courtneyholcomb
force-pushed
the
court/custom-offset7
branch
2 times, most recently
from
118b710 to
5455fe5
Compare
courtneyholcomb
force-pushed
the
court/custom-offset6
branch
2 times, most recently
from
d0c473a to
bebe99d
Compare
courtneyholcomb
force-pushed
the
court/custom-offset7
branch
2 times, most recently
from
3d9de58 to
b53a655
Compare
courtneyholcomb
changed the base branch from
court/custom-offset6
to
court/custom-offset6.5
courtneyholcomb
force-pushed
the
court/custom-offset7
branch
2 times, most recently
from
d260a66 to
75042dd
Compare
courtneyholcomb
force-pushed
the
court/custom-offset6.5
branch
from
ac725b7 to
ff3d3f9
Compare
courtneyholcomb
force-pushed
the
court/custom-offset7
branch
4 times, most recently
from
eda848f to
1e2b931
Compare
courtneyholcomb
force-pushed
the
court/custom-offset7
branch
from
1e2b931 to
7ba3e07
Compare
courtneyholcomb
added
the
Run Tests With Other SQL Engines
courtneyholcomb
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
courtneyholcomb
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
courtneyholcomb
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
courtneyholcomb
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
github-actions
bot
removed
the
Run Tests With Other SQL Engines
courtneyholcomb
force-pushed
the
court/custom-offset7
branch
from
7ba3e07 to
35c74fd
Compare
courtneyholcomb
added
the
Run Tests With Other SQL Engines
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
plypaul
approved these changes
Dec 19, 2024
| docstring: | ||
| Gives a side by side comparison of bookings and bookings_offset_one_martian_day. | ||
| --- | ||
| metric_time__martian_day metric_time__day bookings bookings_offset_one_martian_day |
There was a problem hiding this comment.
- With how
martian_dayis defined, it's a little hard to check these snapshots for correctness. - A more straightforward mapping would help e.g. martian days are always 10 years before.
- Also time on Mars is represented differently externally, so a different name would help.
There was a problem hiding this comment.
Since it's not totally relevant to this PR, I'm going to update this at the top of the stack if you don't mind!
courtneyholcomb
force-pushed
the
court/custom-offset6.5
branch
from
ff3d3f9 to
e073215
Compare
courtneyholcomb
force-pushed
the
court/custom-offset7
branch
3 times, most recently
from
a6ad1d6 to
49c5ce6
Compare
courtneyholcomb
force-pushed
the
court/custom-offset6.5
branch
from
3340fd8 to
b12476e
Compare
courtneyholcomb
force-pushed
the
court/custom-offset7
branch
from
49c5ce6 to
4ad304c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for custom offset window. The snapshots in this PR should give you a better idea of what the SQL and output should look like.