Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include css/bootstrap.css bower.json in "main" #28

Closed
wants to merge 1 commit into from
Closed

Include css/bootstrap.css bower.json in "main" #28

wants to merge 1 commit into from

Conversation

hoppy-kamper
Copy link

I noticed this was missing when trying to do a grunt build with Yeoman scaffold. It looks like the css reference was mistakenly taken out when the font files were removed. See Bootstraps bower.json https://github.com/twbs/bootstrap/blob/master/bower.json

I noticed this was missing when trying to do a grunt build with Yeoman scaffold. It looks like the css reference was mistakenly taken out when the font files were removed. See Bootstraps bower.json https://github.com/twbs/bootstrap/blob/master/bower.json
@dbtek
Copy link
Owner

dbtek commented Feb 2, 2016

Hi @Kamps-Duac,

Thanks for the PR. I think you missed that there is no css file in main section. With bootstrap/16359 css & font files are removed from main to comply with bower spec.

This project as a bootstrap distribution follows same approach. Override method @moravcik suggested on #27 could be useful for those using tools like wiredep.

Edit: wrong credit.

@dbtek dbtek closed this Feb 2, 2016
@hoppy-kamper
Copy link
Author

K thanks!

@hoppy-kamper hoppy-kamper deleted the Kamps-Duac-patch-bower-css branch February 2, 2016 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants