docs: mention receive_X_changes in dbus_proxy #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeenix
requested changes
Oct 16, 2024
| @@ -106,6 +106,9 @@ mod utils; | |||
| /// a [`zbus::message::Message`] wrapper, named `<SignalName>`. This wrapper provides type safe | |||
| /// access to the signal arguments. It also implements `Deref<Target = Message>` to allow easy | |||
| /// access to the underlying [`zbus::message::Message`]. | |||
| /// | |||
| /// For each property with `emits_changed_signal` = `"true"` or `"invalidates"`, this macro will | |||
There was a problem hiding this comment.
Suggested change
| /// For each property with `emits_changed_signal` = `"true"` or `"invalidates"`, this macro will | |
| /// For each property with `emits_changed_signal` set to `"true"` (default) or `"invalidates"`, this macro will |
| @@ -106,6 +106,9 @@ mod utils; | |||
| /// a [`zbus::message::Message`] wrapper, named `<SignalName>`. This wrapper provides type safe | |||
| /// access to the signal arguments. It also implements `Deref<Target = Message>` to allow easy | |||
| /// access to the underlying [`zbus::message::Message`]. | |||
| /// | |||
| /// For each property with `emits_changed_signal` = `"true"` or `"invalidates"`, this macro will | |||
| /// provide a method names `receive_<property_name>_changed` that creates a [`zbus::PropertyStream`]. | |||
There was a problem hiding this comment.
Suggested change
| /// provide a method names `receive_<property_name>_changed` that creates a [`zbus::PropertyStream`]. | |
| /// provide a method named `receive_<property_name>_changed` that creates a [`zbus::PropertyStream`] | |
| /// for the property. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to convert this to a documentation request issue rather than merging this PR.