-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled writing of location and description in DICOM SR file #228
Open
MarcoBologna91
wants to merge
10
commits into
dcmjs-org:master
Choose a base branch
from
MarcoBologna91:annotation_fixing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5879aed
Enabled writing of location and description in DICOM SR file
MarcoBologna91 4d35663
Change in codeValue for location and description tags
MarcoBologna91 ada1c93
Enabled reading of location and description from DICOM SR
MarcoBologna91 4a73a0f
Angle tool added
MarcoBologna91 f337cb1
Rectangle tool added
MarcoBologna91 48cb5fc
Lack of description and location handled
MarcoBologna91 745704b
Enabled the loading and writing on cached statistics for rectangle an…
MarcoBologna91 402a064
Enabled saving of the tail position for the arrow annotation
MarcoBologna91 efa4ea9
Added checkMeasurementIntegrity in cornerstone adapters
MarcoBologna91 15b05bc
Enabled loading of 2D segmentations
MarcoBologna91 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,8 @@ export default class TID300Measurement { | |
...this.getTrackingGroups(), | ||
...this.getFindingGroup(), | ||
...this.getFindingSiteGroups(), | ||
...this.getLocation(), | ||
...this.getDescription(), | ||
...contentSequenceEntries | ||
]; | ||
} | ||
|
@@ -94,4 +96,48 @@ export default class TID300Measurement { | |
}; | ||
}); | ||
} | ||
|
||
getLocation() { | ||
let location = this.props.location; | ||
|
||
console.log(this.props); | ||
|
||
if (!location) { | ||
return []; | ||
} | ||
|
||
return [ | ||
{ | ||
RelationshipType: "HAS OBS CONTEXT", | ||
ValueType: "TEXT", | ||
ConceptNameCodeSequence: { | ||
CodeValue: "112041", | ||
CodingSchemeDesignator: "DCM", | ||
CodeMeaning: "Location" | ||
}, | ||
TextValue: location | ||
} | ||
]; | ||
} | ||
|
||
getDescription() { | ||
let description = this.props.description; | ||
|
||
if (!description) { | ||
return []; | ||
} | ||
|
||
return [ | ||
{ | ||
RelationshipType: "HAS OBS CONTEXT", | ||
ValueType: "TEXT", | ||
ConceptNameCodeSequence: { | ||
CodeValue: "112042", | ||
CodingSchemeDesignator: "DCM", | ||
CodeMeaning: "Description" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similarly this one appears to mean "Target Lesion Partial Response" |
||
}, | ||
TextValue: description | ||
} | ||
]; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide a link to the definition of this code?
From this document it seems that this code means "Target Lesion Complete Response".
http://dicom.nema.org/medical/dicom/current/output/chtml/part16/chapter_D.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we want to use "121226 Approximate spatial location"
"The approximate geometric location on an image or in space where an entity is located."