Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RouterOS container fails to start in actions #224

Open
maksym-nazarenko opened this issue Feb 28, 2024 · 3 comments · May be fixed by #235
Open

RouterOS container fails to start in actions #224

maksym-nazarenko opened this issue Feb 28, 2024 · 3 comments · May be fixed by #235
Labels
bug Something isn't working

Comments

@maksym-nazarenko
Copy link
Collaborator

maksym-nazarenko commented Feb 28, 2024 •
edited
Loading

Tests fail for the latest RouterOS container.

Running qemu-system-x86_64 fails with error:

$ qemu-system-x86_64 -serial mon:stdio -nographic -m 512 -smp 4,sockets=1,cores=4,threads=1 -cpu host -nic tap,id=qemu1,mac=54:05:AB:CD:12:31,script=/routeros/qemu-ifup,downscript=/routeros/qemu-ifdown -hda chr-7.13.5.vdi

qemu-system-x86_64: CPU model 'host' requires KVM or HVF

If -cpu host is removed from the command it works.

Update (@maksym-nazarenko), 2024-06-23
It is a breaking-chnage in the upstream that prevents using the images on non KVM-enabled systems.
See #232 for a local environment fix which will be expanded to GH actions as well.
@maksym-nazarenko maksym-nazarenko added the bug Something isn't working label Feb 28, 2024
@maksym-nazarenko maksym-nazarenko mentioned this issue Feb 28, 2024
Merged
@maksym-nazarenko maksym-nazarenko mentioned this issue Jun 22, 2024
Merged
@ddelnano
Copy link
Owner

When you say there is a breaking change upstream are you talking about within the https://github.com/EvilFreelancer/docker-routeros project? If so, have you considered making that project's docker image more runtime configurable (allowing -cpu to be overridden)?

@maksym-nazarenko
Copy link
Collaborator Author

@ddelnano yes, I'm talking about that project.
The fix is relatively easy, but considering the origin of that project, I'l rather spend week integrating another solution that contributing to upstream.

The qemu-docker project seems mature and configurable to me (it's even possible to access the VM via VNC in your browser to debug :) )

Anyway, it's up to you to make a decision here - I'm just making a proposal for the change.

@ddelnano
Copy link
Owner

Thanks for the background. I'm ok with moving forward with that, just want to make sure I understand the situation :)

@maksym-nazarenko maksym-nazarenko linked a pull request Jul 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use mnazarenko/docker-routeros maksym-nazarenko/terraform-provider-mikrotik
2 participants
@ddelnano @maksym-nazarenko