Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: fix marshaling of int64 type #222

Conversation

maksym-nazarenko
Copy link
Collaborator

Closes #221

@ddelnano
Copy link
Owner

Thanks for fixing this @maksym-nazarenko!

@ddelnano
Copy link
Owner

ddelnano commented Feb 27, 2024

Hm, the build for the latest RouterOS seems to be failing. Upon looking at it briefly it seems like doesn't seem related to your change, but I wasn't able to dig into it right now.

I did notice that the evilfreelancer/docker-routeros project has automated creating new docker images (EvilFreelancer/docker-routeros#20). I wonder if it's also failing on master and is independent of your change.

Re-requesting review until we uncover what is wrong with the latest build. Feel free to proceed with merging if it isn't something that requires a review (if master is experiencing the same issue but passes locally, etc).

@ddelnano ddelnano self-requested a review February 27, 2024 02:52
@maksym-nazarenko
Copy link
Collaborator Author

created #224
It is and issue with upstream RouterOS container

@ddelnano
Copy link
Owner

Thanks for investigating. No concern on my end with proceeding to merge.

@maksym-nazarenko maksym-nazarenko merged commit 8987b30 into ddelnano:master Feb 28, 2024
3 of 4 checks passed
@maksym-nazarenko maksym-nazarenko deleted the fix/client-marshal-int64-type branch February 28, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wireguard endpoint port and keepalives don't work
2 participants