Launch with ddev adminer instead of launcha -a

[mejta]

The Issue

The current way to launch Adminer is via ddev launcha -a. It's different from how e.g. PHPMyAdmin is launched (ddev phpmyadmin).

How This PR Solves The Issue

PR changes launching the Adminer the same way like PHPMyAdmin:
ddev adminer

Manual Testing Instructions

Run ddev adminer

[tyler36]

Thank you for the PR @mejta .

I believe the original idea with ddev launcha -a was to be similar to ddev launch -a which was used to launch PHPmyadmin.
Now that PHPmyadmin has been removed from the default DDEV install (from 1.22), it's probably a good time to discuss this.

[rfay]

I like this and think it's a good idea, but it doesn't seem like it accomplishes anything to remove launcha. If you leave launcha in there at least for a year or so, it will help people to adapt.

[mejta]

@tyler36 Thank you for your comment. @rfay Thank you for the code review and the change suggestion. I put launcha back, so both commands are supported, but launcha is deprecated now. Please review the changes again. Thank you, and thank you for bringing ddev to live; it's a super-useful tool!

[rfay]

This can be tested manually with ddev get https://github.com/mejta/ddev-adminer/tarball/main

[rfay]

@mejta in the future, you'll be a lot happier creating a named branch for PRs. That way, the next time you create a PR (or need the main branch for something else) life will be a lot better.

[rfay]

Looks good, tested manually and it works right. It's a lot better than the launcha approach. Let's remember to remove launcha in a few months?

[rfay]

I opened

• Remove launcha Feb 2024 #17

But... as I was writing it I thought maybe we'd be better to just go ahead and change ddev launcha so it tells people to use ddev adminer. That's what we did with ddev launch -p too...

[mejta]

Thank you, @rfay, for approving the request. Next time, I will create a separate branch for that. Also, I will add an event to remove launcha in February :)

[mejta]

@rfay I've created the separate pull request #18 that has all the changes from this pull request, but in addition, it is in a separate branch and adds an error message for launcha command, so the user knows how to use it. Feel free to use any of the pull requests.