Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: launch ddev adminer by port, remove ddev launcha, move ddev adminer to project level #24

Merged
merged 3 commits into from
Jul 6, 2024

Conversation

stasadev
Copy link
Member

@stasadev stasadev commented Jun 10, 2024

The Issue

Launch can be simpler with DDEV v1.23.0+

How This PR Solves The Issue

Refactors the code. Adds volumes from:

Moves ddev adminer command from ~/.ddev/commands/host/adminer to $DDEV_APPROOT/.ddev/commands/host/adminer

And removes ddev launcha completely (almost a year this command is not intended to be used).

ddev get https://github.com/ddev/ddev-adminer/tarball/20240611_stasadev_launch
ddev restart
ddev adminer

@stasadev stasadev changed the title refactor: launch ddev adminer by port refactor: launch ddev adminer by port, remove ddev launcha, move ddev adminer to project level Jun 10, 2024
@stasadev
Copy link
Member Author

I just removed ddev launcha, it's not needed because people who will update the add-on, will have it in their global commands anyway (it won't be removed), and people who will install the add-on for the first time won't know about it anyway because README.md doesn't mention it.

@rfay rfay requested a review from bserem June 10, 2024 22:43
@tyler36
Copy link
Collaborator

tyler36 commented Jun 11, 2024

I just removed ddev launcha ...

Great idea.

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly, thanks!

install.yaml Outdated Show resolved Hide resolved
@rfay rfay merged commit 22460ca into main Jul 6, 2024
2 checks passed
@rfay rfay deleted the 20240611_stasadev_launch branch July 6, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants