Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
GitLab Templates uses
core/.eslintrc.passing.json
configuration. Quoting from https://git.drupalcode.org/project/gitlab_templates/-/blob/main/docs/jobs/eslint.md?ref_type=heads#eslintThe
core/.eslintrc.passing.json
config includes/mergescore/.eslintrc.json
andcore/..eslintrc.jquery.json
.But this add-on only uses
core/.eslintrc.json
, meaningcore/.eslintrc.jquery.json
is ignored. It happens that you test locally withddev eslint
but in CI pipeline you will get failures caused by runningcore/.eslintrc.jquery.json
How This PR Solves The Issue
Aligns
ddev eslint
with GitLab Templates.Manual Testing Instructions
ddev eslint
against JS with a lot of jQuery. The test passed.Automated Testing Overview
N/A
Related Issue Link(s)
None
Release/Deployment Notes
N/A