-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: dotenv support - allow to change the used OpenSearch version (ddev 1.23.5) #7
Conversation
Add the following variables: - OPENSEARCH_TAG -> defines the tag of the used opensearch image - INSTALL_PLUGIN_ANALYSIS_PHONETIC: boolean var - INSTALL_PLUGIN_ANALYSIS_ICU: boolean var docker-compose is now passing the args to the used Dockerfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you!
Let's replace ddev get
with ddev add-on get
in the bats tests and add release tag to bats, see:
Thank you, and the release test can also be updated to: # bats test_tags=release
@test "install from release" {
set -eu -o pipefail
cd ${TESTDIR} || ( printf "unable to cd to ${TESTDIR}\n" && exit 1 )
echo "# ddev add-on get ${ADDON_PATH} with project ${PROJNAME} in ${TESTDIR} ($(pwd))" >&3
ddev add-on get ${ADDON_PATH}
health_checks
}
|
Sorry. Forgot it... One second. |
Co-authored-by: Stanislav Zhuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
Thanks for reviewing it. |
Add the following variables:
docker-compose is now passing the args to the used Dockerfile
The Issue
Solve #6
How This PR Solves The Issue
Manual Testing Instructions
Use new ddev 1.23.5 and define a dotenv file.
ddev dotenv set .ddev/.env.opensearch --opensearch-tag=2.15.0 --opensearch-dashboards-tag=2.15.0 --install-plugin-analytics-phoenetic=false --install-plugin-analytics-icu=false ddev add-on get https://github.com/cmuench/ddev-opensearch/tarball/feature/dotenv-support
Related Issue Link(s)
Release/Deployment Notes
It should not have affects.