Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use redis:6-bullseye to support old systems, update GitHub test workflow #17

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Use redis:6-bullseye to support old systems, update GitHub test workflow #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b0e319
Use redis:6-bullseye
stasadev Jul 28, 2023
ae128e4
Update actions/checkout to v3
stasadev Jul 28, 2023
ba45a61
Use the full name for Redis image
stasadev Jul 28, 2023
eda1b68
Use Ubuntu 22.04 in tests
stasadev Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ permissions:

env:
NIGHTLY_DDEV_PR_URL: "https://nightly.link/ddev/ddev/actions/runs/1720215802/ddev-linux-amd64.zip"
# Allow ddev get to use a github token to prevent rate limiting by tests
# Allow ddev get to use a GitHub token to prevent rate limiting by tests
DDEV_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# Allow `--HEAD` flag when running tests against HEAD
HOMEBREW_NO_INSTALL_FROM_API: 1
# Pull the same image as in docker-compose.redis.yaml
REDIS_IMAGE: redis:6-bullseye
jobs:
tests:
defaults:
Expand All @@ -40,10 +40,10 @@ jobs:
# ddev_version: [PR]
fail-fast: false

runs-on: ubuntu-20.04
runs-on: ubuntu-22.04

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Set up Homebrew
id: set-up-homebrew
uses: Homebrew/actions/setup-homebrew@master
Expand Down Expand Up @@ -74,7 +74,7 @@ jobs:
- name: Download docker images
run: |
mkdir junk && pushd junk && ddev config --auto && ddev debug download-images >/dev/null
docker pull redis:6 >/dev/null
docker pull ${REDIS_IMAGE} >/dev/null
- name: tmate debugging session
uses: mxschmitt/action-tmate@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.redis.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
services:
redis:
container_name: ddev-${DDEV_SITENAME}-redis
image: redis:6
image: redis:6-bullseye
stasadev marked this conversation as resolved.
Show resolved Hide resolved
# These labels ensure this service is discoverable by ddev.
labels:
com.ddev.site-name: ${DDEV_SITENAME}
Expand Down