Remove Drupal related add-on files from .ddev when not applicable

[stasadev]

The Issue

When people install this add-on, some Drupal related files are installed to .ddev folder, even when the project is not Drupal.

How This PR Solves The Issue

Removes these files in post_install_action.

Manual Testing Instructions

Files are removed for non Drupal:

ddev config --project-type php
ddev add-on get https://github.com/ddev/ddev-redis/tarball/20241028_stasadev_drupal_files
...
Executing post-install actions:
Removing redis/scripts/settings.ddev.redis.php as not applicable
Removing redis/scripts/setup-drupal-settings.sh as not applicable
...

Files are NOT removed for Drupal:

ddev config --project-type drupal
ddev add-on get https://github.com/ddev/ddev-redis/tarball/20241028_stasadev_drupal_files
...
Executing post-install actions: 
Settings file name: /home/stas/code/ddev/d11/web/sites/default/settings.php
...

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

[rfay]

This seems fine, but I didn't understand turning silent results into errors.

[rfay]

Why does this have to be called out as an error?

[stasadev]

Because I remove the files only if this script fails:

if ! redis/scripts/setup-drupal-settings.sh; then
  # remove files
fi

That's why I return an error here.
Otherwise I would need to duplicate Drupal checks in install.yaml

[rfay]

How about checking to see if it's drupal and if not removing files? Rather than depending on the script? Or is that the same?

[stasadev]

If I remove the file from the file itself, will this work for all environments?

I thought it could have unpredictable results, for example, for Windows.

[stasadev]

Okay, I'll try to remove the files here and see if it works.

[stasadev]

It works for me.

[stasadev]

I tested it again on Linux, macOS, and traditional Windows. Works perfectly.

[rfay]

Thanks, sorry I didn't get back to it.