#29 automated tests are failing (#30)

ddev · Sep 26, 2024 · 18fbe68 · 18fbe68
1 parent 5fad44e
commit 18fbe68
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -34,7 +34,11 @@ jobs:
         ddev_version: [stable, HEAD]
       fail-fast: false
 
-    runs-on: ubuntu-latest
+    # We need to use the ubuntu-20.04 image because the sqlsrv service uses the
+    # mcr.microsoft.com/mssql/server:2019-CU12-ubuntu-20.04 image.
+    # See the issue https://github.com/ddev/ddev-sqlsrv/issues/29 for more
+    # details.
+    runs-on: ubuntu-20.04
 
     steps:
       - uses: ddev/github-action-add-on-test@v2

diff --git a/docker-compose.sqlsrv.yaml b/docker-compose.sqlsrv.yaml
@@ -4,8 +4,10 @@ services:
     container_name: ddev-${DDEV_SITENAME}-sqlsrv
     hostname: ddev-${DDEV_SITENAME}-sqlsrv
 
-    # For possible options: https://hub.docker.com/_/microsoft-mssql-server.
-    # This does not yet work with Apple M1. See: https://github.com/microsoft/mssql-docker/issues/734
+    # For available options look at https://hub.docker.com/_/microsoft-mssql-server.
+    # This image that does not work with Apple M1 yet. For more details:
+    # - https://github.com/microsoft/mssql-docker/issues/734
+    # - https://github.com/microsoft/mssql-docker/issues/802
     image: mcr.microsoft.com/mssql/server:2019-CU12-ubuntu-20.04
 
     user: root