Exclude Drive Activity from the server's Google account. #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that the drive API counts various actions taken by the server account in the process of creating a new document for a puzzle as edits (in that the edit field is populated). This is confusing as it looks like there is drive activity in every new puzzle when it is first created, even if nobody has opened it or edited the document. We can filter out events associated with the ID of the server account to prevent this confusion. Given that this account is recommended to not be one used for actual hunting, this seems like a reasonable approach. We were not previously storing the ID when logging into a server account. We store it for future sign-ins, but for simplicity, do not bother with backfill. This means that until the server admin signs in again, they will continue to see activity under the server admin. Also note that regardless of which account you're logged into JR with, Sheets activity will be associated with the default Google account in your browser session.
jpd236
force-pushed
the
gdrive-activity
branch
from
64851a8 to
6e17b09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the drive API counts various actions taken by the server account in the process of creating a new document for a puzzle as edits (in that the edit field is populated). This is confusing as it looks like there is drive activity in every new puzzle when it is first created, even if nobody has opened it or edited the document.
We can filter out events associated with the ID of the server account to prevent this confusion. Given that this account is recommended to not be one used for actual hunting, this seems like a reasonable approach.
We were not previously storing the ID when logging into a server account. We store it for future sign-ins, but for simplicity, do not bother with backfill. This means that until the server admin signs in again, they will continue to see activity under the server admin.
Also note that regardless of which account you're logged into JR with, Sheets activity will be associated with the default Google account in your browser session.
See #2280