DBZ-8069 Add override.data.change.topic.prefix property to TableTopicNamingStrategy #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpechane this one is also ready for review. thanks in advance! |
Naros
reviewed
Jul 18, 2024
| @@ -29,7 +34,13 @@ public static TableTopicNamingStrategy create(CommonConnectorConfig config) { | |||
|
|
|||
| @Override | |||
| public String dataChangeTopic(TableId id) { | |||
| String topicName = mkString(Collect.arrayListOf(prefix, id.table()), delimiter); | |||
| String topicName; | |||
| if (overrideDataChangeTopicPrefix != null) { | |||
There was a problem hiding this comment.
Suggested change
| if (overrideDataChangeTopicPrefix != null) { | |
| if (!Strings.isNullOrBlank(overrideDataChangeTopicPrefix)) { |
|
Thanks @twthorn, would you please open an accompanying PR in the main repository to document this new configuration option for the table naming strategy for Vitess? |
|
@Naros Yes, of course, here's the PR to update docs debezium/debezium#5698 |
Naros
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.redhat.com/browse/DBZ-8069 for more context on why this needed
See also this Zulip chat on why we went this route https://debezium.zulipchat.com/#narrow/stream/302529-community-general/topic/Separate.20logs.2Fmetrics.20for.20identical.20topic.2Eprefix.20connectors
Expand our current custom vitess topic naming strategy to support this additional config.