DBZ-7749 Add pod securityContext from templates #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chrisrecalis Thanks for spotting this and contributing a fix. I created a ticket for it: https://issues.redhat.com/browse/DBZ-7749 Could you please prefix the commit message with |
chrisrecalis
changed the title
|
@jcechace I have fixed the commit message. I'm not sure what the formatting issue is, could you help me fix it / point me to how to test formatting? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing securityContext from templates.
Currently only the container securityContext is being set. When using file based storage for offsets this requires the container to run as root to be able to access the volume since we can't set the fsGroup on the pod level