Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/front end tests #148

Merged
merged 4 commits into from
Feb 26, 2023

Conversation

davidlag0
Copy link

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe): Tests

What is the current behavior?

Issue Number: #135

What is the new behavior?

Snapshot tests for components NetworkManagement, Bar and HomeLoggedIn

Does this introduce a breaking change?

  • Yes
  • No

Other information

@davidlag0 davidlag0 requested a review from dec0dOS as a code owner February 26, 2023 21:51
Copy link
Owner

@dec0dOS dec0dOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the dependencies comments. In the code seems to be everything if fine. Thank you for your work, @davidlag0!

frontend/package.json Show resolved Hide resolved
frontend/package.json Show resolved Hide resolved
@davidlag0
Copy link
Author

@dec0dOS Good catch for the missing dependencies. Should be resolved now.

@dec0dOS dec0dOS merged commit be0cc0c into dec0dOS:test/front_end_tests Feb 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants